community icon indicating copy to clipboard operation
community copied to clipboard
verified publisher icon aws-controllers-k8s

Adding DBInstance.enableCloudwatchLogsExports doesn't update the RDS instance

Open madhusudancs opened this issue 1 year ago • 8 comments

Describe the bug Setting enableCloudwatchLogsExports on a DBInstance object won't have any effect if this field is set after the instance is created.

Steps to reproduce Create a DBInstance object and do not set the spec.enableCloudwatchLogsExports field. Once the instance is created, add that field.

Expected outcome RDS instance to be modified, but it isn't.

Environment

  • Kubernetes version: 1.29
  • Using EKS (yes/no), if so version? yes (1.29?)
  • AWS service targeted (S3, RDS, etc.): RDS

Also AFAICT, https://github.com/aws-controllers-k8s/community/issues/1845 and subsequently https://github.com/aws-controllers-k8s/rds-controller/pull/161 fixed it for DBCluster, but not for DBInstance. Could we please fix this?

madhusudancs avatar Aug 11 '24 05:08 madhusudancs

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Feb 09 '25 19:02 ack-bot

Stale issues rot after 60d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 60d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot avatar Apr 10 '25 19:04 ack-bot

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

ack-bot avatar Jun 09 '25 20:06 ack-bot

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Jun 09 '25 20:06 ack-prow[bot]

/reopen

knottnt avatar Jun 09 '25 21:06 knottnt

@knottnt: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Jun 09 '25 21:06 ack-prow[bot]

/remove-lifecycle rotten

michaelhtm avatar Jun 10 '25 17:06 michaelhtm

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Dec 07 '25 23:12 ack-bot