rds-controller makes unnecessary updates to DBSubnetGroups
Describe the bug While looking at logs from the rds-controller version v1.1.2 I saw the following log line:
ack-rds-controller-rds-chart-658df64797-cv7lg controller 2023-04-26T08:09:54.651Z
INFO ackrt desired resource state has changed
{"account": "redacted", "role": "", "region": "eu-west-1", "kind": "DBSubnetGroup",
"namespace": "default", "name": "private-subnets-redacted", "is_adopted": true,
"generation": 2, "diff":
[{"Path":{"Parts":["Spec","SubnetIDs"]},"A":["subnet-xxx860164a0","subnet-xxx547ae34f","subnet-xxx27e5227d"],
"B":["subnet-xxx860164a0","subnet-xxx547ae34f","subnet-xxx27e5227d","subnet-xxx27e5227d",
"subnet-xxx860164a0","subnet-xxx547ae34f"]}]}
The subnets are just repeated. No actual update is required.
Steps to reproduce I expect simply creating a subnet group and restarting the controller should show this log line.
Expected outcome Prevent unnecessary updates.
Environment
- Kubernetes version
- Using EKS (yes/no), if so version?
- AWS service targeted (S3, RDS, etc.)
I am experiencing the same with rds-v1.1.4 - there is no change over the subnetIDs, yet the controller INFO ackrt desired resource state has changed
Here the full logs:
// 2023-07-03T07:20:21.335Z INFO ackrt desired resource state has changed
{
"account": "<masked>",
"role": "",
"region": "me-south-1",
"kind": "DBSubnetGroup",
"namespace": "aws-rds",
"name": "dbsubgrp-rds-mssql",
"is_adopted": false,
"generation": 1,
"diff": [
{
"Path": {
"Parts": [
"Spec",
"SubnetIDs"
]
},
"A": [
"subnet-0de319e8bf9aad3d6",
"subnet-07c7c491e929dc256",
"subnet-0394c035cfcbe4ee5"
],
"B": [
"subnet-0de319e8bf9aad3d6",
"subnet-07c7c491e929dc256",
"subnet-0394c035cfcbe4ee5",
"subnet-07c7c491e929dc256",
"subnet-0394c035cfcbe4ee5",
"subnet-0de319e8bf9aad3d6"
]
}
]
}
// 2023-07-03T07:20:21.555Z INFO ackrt updated resource
{
"account": "<masked>",
"role": "",
"region": "me-south-1",
"kind": "DBSubnetGroup",
"namespace": "aws-rds",
"name": "dbsubgrp-rds-mssql",
"is_adopted": false,
"generation": 1
}
This thing happens every time the rds controller is started for sure, however I remember seeing this on a regular basis - maybe each day - just lost those logs now and can't confirm.
any update ?
Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale
Stale issues rot after 60d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 60d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten
Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale
Stale issues rot after 60d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 60d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten
Rotten issues close after 60d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close
@ack-bot: Closing this issue.
In response to this:
Rotten issues close after 60d of inactivity. Reopen the issue with
/reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
duplicate of https://github.com/aws-controllers-k8s/community/issues/2083