community icon indicating copy to clipboard operation
community copied to clipboard

Published 20 hours ago • verified publisher icon aws-controllers-k8s

Secrets Integration Lambda ACK

Open seanmcguigan opened this issue 1 year ago • 9 comments

Is your feature request related to a problem? Problem similar to Alice's problem only for the Lambda ACK. There is no way to reference secrets that are already defined in k8s as Lambda env vars.

Describe the solution you'd like I would like to see an option to do the following:

spec:
  environment:
    variables:
      FOO: "bar"
      SECRET_USERNAME:
        from:
          secretKeyRef:
            name: backend-user
            key: backend-username

Describe alternatives you've considered An alternative would be to encrypt the manifest in version control with something like SOPS, but that's not really an option.

seanmcguigan avatar Mar 01 '23 14:03 seanmcguigan

Hi @seanmcguigan , thank you for raising this issue. I agree that it would be a useful addition. However, it might be challenging to support both plain strings and secret references with the Environment.Variable type, which is of type map[string]*string. One possible solution could be to create a new field called Environment.SecretVariables specifically for referencing secrets while continuing to use Environment.Variables for plain strings. Quick thoughts on this, I think it might be doable without having to mess with the code-generator.

a-hilaly avatar Mar 01 '23 16:03 a-hilaly

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar May 30 '23 20:05 ack-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot avatar Jun 29 '23 21:06 ack-bot

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

ack-bot avatar Aug 28 '23 23:08 ack-bot

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Aug 28 '23 23:08 ack-prow[bot]

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Mar 09 '24 19:03 ack-bot

/remove-lifecycle stale

gecube avatar Mar 13 '24 06:03 gecube

Hi, any updates on this ?

blueacidification avatar Aug 01 '24 09:08 blueacidification