community icon indicating copy to clipboard operation
community copied to clipboard

ACK for RDS to support `RestoreDBClusterToPointInTime`

Open abatilo opened this issue 2 years ago • 12 comments

Is your feature request related to a problem? I would like to be able to create DBCluster's from a latest restorable time based on an existing DBCluster.

I'd like to be able to combine the ACK for RDS controller with something like the ArgoCD ApplicationSet controller's PR generator, so that I could create new databases based on the main environment, and then have them be torn down automatically by deleting the custom resource.

Describe the solution you'd like I'd like the ACK for RDS to better support RestoreDBClusterToPointInTime

abatilo avatar Feb 06 '23 15:02 abatilo

CC @aws-controllers-k8s/rds-maintainer could someone please take a look here and determine the complexity of implementing this?

jljaco avatar Feb 15 '23 19:02 jljaco

My work organization could be open to contributing the work if some initial guidance could be provided?

abatilo avatar Feb 16 '23 14:02 abatilo

My work organization could be open to contributing the work if some initial guidance could be provided?

@abatilo we are always available to help. :) Hop onto the Kubernetes Slack community #aws-controllers-k8s channel. That's the best way to get into design discussions. Myself and @brucegucode can assist you in planning this feature out.

jaypipes avatar Feb 16 '23 16:02 jaypipes

I would also point out a previous PR in the rds-controller repository that might be useful as reference: https://github.com/aws-controllers-k8s/rds-controller/pull/101

RedbackThomson avatar Feb 16 '23 16:02 RedbackThomson

aws-controllers-k8s/rds-controller#101 lets you restore a database fully from snapshot, but it does not let you select the point-in-time. Here is a walkthrough on how to do that.

To go to an exact point-in-time, you would need:

There are definitely a bunch of use cases for the above -- I've seen the need for this from Kubernetes and have done similar things myself :smile:

@abatilo For your specific use case, is there a need to restore to a specific point in time or does restoring from the last snapshot work?

jkatz avatar Feb 16 '23 19:02 jkatz

For my use case, restoring to latest with specifically Aurora Postgres is all I'm looking to do at the moment @jkatz.

Thank you for the reference PRs. I don't want to say we're committing to anything just yet but those are some great starting points!

abatilo avatar Feb 16 '23 20:02 abatilo

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar May 18 '23 16:05 ack-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot avatar Jun 17 '23 21:06 ack-bot

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

ack-bot avatar Aug 16 '23 22:08 ack-bot

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Aug 16 '23 22:08 ack-prow[bot]

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

ack-bot avatar Sep 16 '24 17:09 ack-bot

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Sep 16 '24 17:09 ack-prow[bot]

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

ack-bot avatar Nov 15 '24 17:11 ack-bot

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 60d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Nov 15 '24 17:11 ack-prow[bot]