community icon indicating copy to clipboard operation
community copied to clipboard

Errors while generating `sagemaker-controller` for ACK runtime `v0.20.1`, code-generator `v0.20.1`

Open ack-bot opened this issue 3 years ago • 0 comments

Errors while generating sagemaker-controller for ACK runtime v0.20.1, code-generator v0.20.1

stdout for make build-controller:

building ack-generate ... ok.
==== building sagemaker-controller ====
Copying common custom resource definitions into sagemaker
Building Kubernetes API objects for sagemaker
Generating deepcopy code for sagemaker
Generating custom resource definitions for sagemaker
Building service controller for sagemaker

stderr for make build-controller:

Error: template: /home/prow/go/src/github.com/aws-controllers-k8s/code-generator/templates/pkg/resource/tags.go.tpl:19:21: executing "/home/prow/go/src/github.com/aws-controllers-k8s/code-generator/templates/pkg/resource/tags.go.tpl" at <.CRD.GetTagField>: error calling GetTagField: tag field path Tags does not exist inside EdgeDeploymentStage crd
make: *** [Makefile:41: build-controller] Error 1

Steps for closing this issue:

  1. Update sagemaker-controller go.mod file to update aws-controllers-k8s/runtime to v0.20.1
  2. Run go mod tidy for sagemaker-controller
  3. Successfully generate the service controller locally using latest release of aws-controllers-k8s/code-generator
  4. Run make test for sagemaker-controller
  5. Run make kind-test from aws-controllers-k8s/test-infra repository for sagemaker-controller
  6. When kind test is successful, Create new pull request for sagemaker-controller
  7. Mention this issue number in the pull request
  8. When the above PR is merged, close this issue

For more guidance, create an issue or reach out on Slack.

ack-bot avatar Sep 12 '22 19:09 ack-bot