community icon indicating copy to clipboard operation
community copied to clipboard

Renaming a Controller

Open ilangofman opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Currently, I am working on the Amazon Managed Service for Prometheus (AMP) controller. Right now, the name of the controller is prometheusservice-controller. I was wondering if it would be possible to rename a controller repository to something more fitting such as amp-controller.

Describe the solution you'd like

I understand right now that the name comes from the aws-sdk-go library. Which the controller imports are based on. Would there be any way to separate the controller name from the sdk import path?

ilangofman avatar Jul 28 '22 17:07 ilangofman

Sorry but all of our tooling and documentation lines up with the current naming scheme. I opened a PR a while ago clarifying what each service uses as their identifiers and where they are used in ACK. It would be a pretty monumental effort for us to refactor this, even just for a single repository.

RedbackThomson avatar Jul 28 '22 19:07 RedbackThomson

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

eks-bot avatar Oct 26 '22 22:10 eks-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

eks-bot avatar Nov 25 '22 22:11 eks-bot

/lifecycle frozen

a-hilaly avatar Nov 27 '22 18:11 a-hilaly

Already released controller cannot be renamed, however, current code-generator supports renaming the controller name/module which is permissible if the controller didn't receive a an official release. /close

a-hilaly avatar Feb 18 '24 04:02 a-hilaly

@a-hilaly: Closing this issue.

In response to this:

Already released controller cannot be renamed, however, current code-generator supports renaming the controller name/module which is permissible if the controller didn't receive a an official release. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-prow[bot] avatar Feb 18 '24 04:02 ack-prow[bot]