community icon indicating copy to clipboard operation
community copied to clipboard

Implement `update` functionality for `RouteTable` resource

Open brycahta opened this issue 2 years ago • 11 comments

Is your feature request related to a problem? ec2-controller supports Create/Delete functionality for RouteTable resource, but not Update. Note: although a customUpdateRouteTable() method is defined here, this was necessary to add Routes to the RouteTable Spec NOT update RouteTable itself

Describe the solution you'd like I should be able to modify/update an ACK-managed RouteTable resource using its controller

Describe alternatives you've considered Updating resource myself using aws-sdk, cli, or console

brycahta avatar Mar 02 '22 20:03 brycahta

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar May 31 '22 23:05 ack-bot

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot avatar Jun 30 '22 23:06 ack-bot

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

ack-bot avatar Jul 30 '22 23:07 ack-bot

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Provide feedback via https://github.com/aws-controllers-k8s/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ack-bot avatar Jul 30 '22 23:07 ack-bot

image

  • Only Edit routes from the list of Console Actions is implemented

  • This issue is blocking: https://github.com/aws-controllers-k8s/community/issues/1291

    • TLDR; RouteTable.Spec.Routes is not updated properly when using references

brycahta avatar Sep 06 '22 17:09 brycahta

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Dec 05 '22 17:12 ack-bot

/remove-lifecycle stale

a-hilaly avatar Dec 05 '22 20:12 a-hilaly

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Mar 14 '23 07:03 ack-bot

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Jun 13 '23 15:06 ack-bot

Issues go stale after 180d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 60d of inactivity and eventually close. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle stale

ack-bot avatar Dec 11 '23 12:12 ack-bot

Stale issues rot after 60d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 60d of inactivity. If this issue is safe to close now please do so with /close. Provide feedback via https://github.com/aws-controllers-k8s/community. /lifecycle rotten

ack-bot avatar Feb 09 '24 13:02 ack-bot