feat: rm.IsSynced returns requeueError when false
Description of changes: This changes introduce a new field in generator.yaml SyncedConfig, which lets us define custom reuqueue duration. If it is not defined, the duration will default to the DefaultSyncPeriod
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: michaelhtm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [michaelhtm]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@michaelhtm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| verify-attribution | 9f2bbca37374e702d6713ca4e351e6f3172bcf56 | link | false | /test verify-attribution |
| s3-olm-test | 9f2bbca37374e702d6713ca4e351e6f3172bcf56 | link | false | /test s3-olm-test |
| ec2-controller-test | 9f2bbca37374e702d6713ca4e351e6f3172bcf56 | link | true | /test ec2-controller-test |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale