code-generator icon indicating copy to clipboard operation
code-generator copied to clipboard

Fix unkeyed struct literals in `metav1.Time` references warnings

Open rushmash91 opened this issue 6 months ago • 9 comments

Description of changes:

fixes compiler warnings related to unkeyed field initialization in metav1.Time struct literals throughout the codebase. Updated all instances to explicitly specify the Time field when initializing metav1.Time structs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

rushmash91 avatar May 14 '25 20:05 rushmash91

/retest

rushmash91 avatar May 14 '25 20:05 rushmash91

are the warnings produced by the compiler (as in go build) or gofmt?

@a-hilaly go build compiler

eg: Screenshot 2025-05-15 at 12 10 41 AM

rushmash91 avatar May 15 '25 07:05 rushmash91

/retest

rushmash91 avatar May 15 '25 07:05 rushmash91

/test ec2-controller-test

rushmash91 avatar May 15 '25 09:05 rushmash91

/test ec2-controller-test

rushmash91 avatar May 15 '25 17:05 rushmash91

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, knottnt, michaelhtm, rushmash91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [a-hilaly,knottnt,michaelhtm,rushmash91]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

ack-prow[bot] avatar May 16 '25 16:05 ack-prow[bot]

go build compiler

Why? I don't understand how the screenshot proofs that it's the compiler

Cc @rushmash91

a-hilaly avatar May 16 '25 16:05 a-hilaly

/retest

knottnt avatar Jun 04 '25 19:06 knottnt

@rushmash91: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution f7f07fd46b813d702a067eed0cbc8d7db2ea50b4 link false /test verify-attribution
s3-olm-test f7f07fd46b813d702a067eed0cbc8d7db2ea50b4 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ack-prow[bot] avatar Jun 04 '25 19:06 ack-prow[bot]