cloudformation-coverage-roadmap icon indicating copy to clipboard operation
cloudformation-coverage-roadmap copied to clipboard

AWS::SNS::Topic - DeliveryStatusLogging (new property)

Open pbsinclair42 opened this issue 6 years ago • 13 comments

Quick Sample Summary:

  1. Scope of request -> New attribute for an existing resource. AWS::SNS::Topic does not currently support configuring the delivery status logging settings, though configuring these settings is currently supported by the AWS SDKs.
  2. Expected behavior -> In Create, allow setting delivery status logging settings. In Update, allow changing delivery status logging settings, which shouldn't require replacement.
  3. Links to existing API doc -> Docs describe how this is done in the SDK here: https://docs.aws.amazon.com/sns/latest/dg/sns-topic-attributes.html , while the API docs themselves do not currently describe this functionality: https://docs.aws.amazon.com/sns/latest/api/API_SetTopicAttributes.html
  4. Category tag -> Other (Application Integration)

pbsinclair42 avatar Jul 31 '19 23:07 pbsinclair42

Hello @pbsinclair42, we are currently working migrating all existing SNS resource to self-service. Once we have successfully onboard to self-service, we should be able to address this request. The estimated timeline for migrating to self-service is in Q1.

yangmarc avatar Jan 13 '21 22:01 yangmarc

SNS Resources are now live in Github. https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-sns. You can fork it and contribute. We are starting to migrate SNS Resources to self-service

yangmarc avatar Jan 25 '21 18:01 yangmarc

@yangmarc, is there an update on this missing feature?

ngamradt-turner avatar Aug 31 '21 18:08 ngamradt-turner

@yangmarc , does this issue need to be migrated to the new repo?

I don't see one there and I didn't want to make a duplicate.

iainelder avatar Dec 07 '21 16:12 iainelder

What is the status of this ticket? @iainelder, what is the other repo that you mentioned?

ngamradt-turner avatar Mar 22 '22 20:03 ngamradt-turner

@ngamradt-turner I was referring to @yangmarc 's linked repo: https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-sns

iainelder avatar Mar 22 '22 20:03 iainelder

@ngamradt-turner @iainelder feel free to contribute to the cfn sns repo. This property can be easily implemented in self service. However, it wont be published to public until official approval by aws cfn team. For now, you can implement and use it for your own benefit.

yangmarc avatar Apr 25 '22 07:04 yangmarc

@yangmarc , thanks for the opportunity to collaborate.

Now I'm not working with SNS resources so I have no immediate need for the feature. I'd be interested to review someone else's implementation if they get to it first.

My question was more one of housekeeping; now that there is a repo for SNS resources, can we move this issue there?

iainelder avatar Apr 26 '22 08:04 iainelder

@iainelder Feel free to open an issue in the SNS resource repo while keeping this issue here in the CFN coverage. This way, it can be seen by both the engineers on SNS team and CFN team. Thanks

yangmarc avatar Apr 28 '22 18:04 yangmarc

As this now is part of SecurityHub https://docs.aws.amazon.com/securityhub/latest/userguide/securityhub-standards-fsbp-controls.html#fsbp-sns-2 it would be awesome if this get fixed SOON.

egut avatar Aug 02 '22 14:08 egut

As of December 2023, SNS supports the configuration of delivery status logging via CloudFormation. Here's the announcement: https://aws.amazon.com/about-aws/whats-new/2023/12/amazon-sns-configuring-delivery-status-logging-aws-cloudformation/

In your template, simply set the DeliveryStatusLogging property, as follows

"Resources": {
    "MySNSTopic" : {
        "Type" : "AWS::SNS::Topic",
        "Properties" : {
            "TopicName" : "TestTopic",
            "DisplayName" : "TEST",
            "SignatureVersion" : "2",
            "DeliveryStatusLogging" : [{
                "Protocol": "sqs",
                "SuccessFeedbackSampleRate": "45",
                "SuccessFeedbackRoleArn": "arn:aws:iam::123456789012:role/SNSSuccessFeedback_test1",
                "FailureFeedbackRoleArn": "arn:aws:iam::123456789012:role/SNSFailureFeedback_test2"
            }]
        }
    }
}

otaviofff avatar Dec 08 '23 04:12 otaviofff