cloudformation-coverage-roadmap icon indicating copy to clipboard operation
cloudformation-coverage-roadmap copied to clipboard

Tagging resource type coverage

Open PatMyron opened this issue 5 years ago • 20 comments

Should be able to tag-on-create and update tags at the system tag-level, stack-level and resource-level for all resource types that support tagging natively without unnecessary resource replacement

https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/4, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/7, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/19, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/28, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/29, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/64, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/69, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/74, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/77, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/84, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/95, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/96, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/117, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/133, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/155, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/176, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/178, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/184, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/193, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/194, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/195, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/196, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/200, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/202, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/203, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/205, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/219, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/231, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/236, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/238, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/248, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/277, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/306, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/309, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/328, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/340, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/350, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/354, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/358, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/394, https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/398

Wonder if tagging should be an issue label..

PatMyron avatar Oct 18 '19 21:10 PatMyron

Hi @PatMyron, I don't see AWS::Glue::Crawler in the above list, which I know suffers the same issue (stack-level tags dont get applied). Also suspect AWS::Glue::Workflow and AWS::Glue::Trigger may have the same, but would need to test. Do you want me to create an issue for these?

andyjgordon avatar Jan 29 '20 11:01 andyjgordon

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

benkehoe avatar Jan 29 '20 14:01 benkehoe

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

But it should be aware of resources that require some interruption or replacement when adding them. Eg. EIP or ElasticBeanstalk Environment

benbridts avatar Jan 29 '20 14:01 benbridts

@PatMyron I see the stack level tags not being applied to AWS::EC2::VPCEndpointService as well, do you want me to create an issue for this?

pareddy113 avatar May 01 '20 18:05 pareddy113

@PatMyron I see the stack level tags not being applied to AWS::EC2::VPCEndpointService as well, do you want me to create an issue for this?

https://github.com/aws-cloudformation/aws-cloudformation-coverage-roadmap/issues/350

PatMyron avatar May 01 '20 20:05 PatMyron

@PatMyron can you update us if there is any progress being made here?

tvb avatar Jul 10 '20 09:07 tvb

@PatMyron Is this really in progress or is more of a low priority issue?

Maycon-Santos-sm avatar Sep 22 '20 08:09 Maycon-Santos-sm

#644 #645

badaldavda8 avatar Oct 05 '20 06:10 badaldavda8

#652

benbridts avatar Oct 13 '20 09:10 benbridts

#742

rgoltz avatar Jan 09 '21 12:01 rgoltz

As support is added for CloudFormation to add its automatic tags to more resource types, there should be a way to get those tags added to existing resources in a stack without providing a changed template.

@benkehoe does your comment covers the fact that explicitly adding Tag to an existing AWS::CloudFront::Distribution does not add the tags (while adding the tags via the console works fine)?

This is not working for an existing distribution:

Distribution:
  Type: AWS::CloudFront::Distribution
  Properties:
    Tags:
      - Key: my-tag-key
        Value: my-tag-value

By the way.. any workaround?

See also https://serverfault.com/questions/898453/aws-cloudformation-change-set-is-not-adding-tags-to-the-resources

yvele avatar Apr 08 '21 21:04 yvele

Please add AWS EMRCluster to this list, CFN stack-level tags are not created. Thank you

CloudFormation automatically creates the following stack-level tags with the prefix aws::

aws:cloudformation:logical-id aws:cloudformation:stack-id aws:cloudformation:stack-name

estanqueiroa avatar Jun 08 '22 19:06 estanqueiroa

#1734 :Add support for stack level tags to AWS::EC2::KeyPair

ayrawat17 avatar Jul 02 '23 21:07 ayrawat17

#1786

aerle avatar Aug 28 '23 21:08 aerle

#1807 #1808

aerle avatar Oct 01 '23 21:10 aerle

#19

zenttic-aws avatar Dec 13 '23 03:12 zenttic-aws

#901

aerle avatar Dec 22 '23 20:12 aerle

#1934

zipkid avatar Feb 26 '24 09:02 zipkid

1939 1940

desikora avatar Feb 29 '24 21:02 desikora

#1460 #1526

rgoltz avatar Jun 11 '24 20:06 rgoltz