cloudformation-cli icon indicating copy to clipboard operation
cloudformation-cli copied to clipboard

removing duplicate module validation caught by cfn-lint

Open PatMyron opened this issue 3 years ago • 6 comments

https://github.com/aws-cloudformation/cloudformation-cli/pull/634 https://github.com/aws-cloudformation/cloudformation-cli/pull/644

left module-specific validation like restrictions on exports, macros/transforms, and nested stacks

PatMyron avatar May 03 '21 19:05 PatMyron

The fragments folder cannot have more than 1 json or yaml file. Can we add this validation? Otherwise it'll fail at runtime during registration

miparnisari avatar May 05 '21 19:05 miparnisari

That validation should already exist, Maria. I had added that a while ago.

MalikAtalla-AWS avatar May 05 '21 19:05 MalikAtalla-AWS

That validation should already exist, Maria. I had added that a while ago.

~I was able to submit a module today with two files inside fragments: s3.json and blabla.json.old~

I had an old version of the CFN CLI

miparnisari avatar May 06 '21 00:05 miparnisari

@MalikAtalla-AWS @PatMyron does this change still apply and/or what rework is needed here?

mircealam avatar Oct 06 '23 20:10 mircealam

My comments are addressed, but the build is failing @mircealam

MalikAtalla-AWS avatar Oct 09 '23 06:10 MalikAtalla-AWS

My comments are addressed, but the build is failing @mircealam

looks like that test was removed in https://github.com/aws-cloudformation/cloudformation-cli/pull/1028 already

PatMyron avatar Nov 21 '23 23:11 PatMyron