aws-cloudformation-templates icon indicating copy to clipboard operation
aws-cloudformation-templates copied to clipboard

MacrosExamples - ExecutionRoleBuilder update and typo

Open Onolisk opened this issue 2 years ago • 2 comments

Hi, an update is required for the awslabs sample here:

https://github.com/awslabs/aws-cloudformation-templates/tree/master/aws/services/CloudFormation/MacrosExamples/ExecutionRoleBuilder

A simple typo in step 4 prevents inexperienced users from progressing. Python runtime to be updated 3.9 as the version specified is deprecated on AWS.

README.md

step 4:

OLD:

aws cloudformation deploy \
    --stack-name ExecutionRoleBuilderCFnMacro.packaged.template \
    --template-file ExecutionRoleBuilderCFnMacro \
    --capabilities CAPABILITY_IAM

NEW:

aws cloudformation deploy \
    --stack-name ExecutionRoleBuilderCFnMacro \
    --template-file ExecutionRoleBuilderCFnMacro.packaged.template  \
    --capabilities CAPABILITY_IAM

macro.template:

Transform: AWS::Serverless-2016-10-31
Resources:
  Function:
    Type: AWS::Serverless::Function
    Properties:
      Runtime: python3.9

Onolisk avatar Jul 04 '23 06:07 Onolisk

Due to inactivity this issue will be closed in 7 days

github-actions[bot] avatar Apr 22 '24 19:04 github-actions[bot]

Keep this open until we decide where the macro examples will live.

ericzbeard avatar Apr 23 '24 15:04 ericzbeard