aws-cloudformation-templates icon indicating copy to clipboard operation
aws-cloudformation-templates copied to clipboard

Published 20 hours ago • verified publisher icon aws-cloudformation

Allow send to send reason – Resolves #198

Open corrjo opened this issue 5 years ago • 4 comments

#198

Added reason to send module

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

corrjo avatar Jun 24 '19 20:06 corrjo

Would love some review. Let me know if there is anything needs to be done. Thanks!

corrjo avatar Jul 07 '19 17:07 corrjo

Very useful update, looking forward for the changes is publicly available. It's important to expose failure reason back to CFN, as LogGroup might be deleted on failed creation, if it is a part of the template.

jaymecd avatar Nov 10 '20 16:11 jaymecd

So this has been approved but never merged. Who has got the power to do that? There is also another PR that's adding the same thing (#382). So you can kill two PRs with one merge.

fraghag avatar Jul 04 '23 15:07 fraghag

Also make sure that if this does get merged here in this template repo, that that change will also be reflected in the cfnresponse module present in the deployed AWS Lambda runtime environments.

gene1wood avatar Jul 04 '23 16:07 gene1wood

#382 was merged. This PR, #198 can be closed

gene1wood avatar Apr 06 '24 19:04 gene1wood