docs icon indicating copy to clipboard operation
docs copied to clipboard

React native picker

Open abdallahshaban557 opened this issue 3 years ago • 2 comments

Issue #, if available:

Description of changes:

Changes to add React Native as a platform picker to the libraries section. Took this opportunity to clean up the documentation as I progressed. This is still a draft.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

abdallahshaban557 avatar Sep 04 '22 22:09 abdallahshaban557

~~also looks like the build is failing on GH with this error:~~

resolved!

tjleing avatar Sep 13 '22 19:09 tjleing

if you select RN as an integration on /start it still sets your filterKeys platform to js (image below) so if you then pick /lib it redirects to JS instead of RN — the logic is in getFilterOverrides.ts. ~looks to me like adding && updates.integration !== "react-native" to line 24 should do it but not totally sure~ ah but then it gets caught by the next if statement, which will set framework = undefined which isn't what we want either. maybe just adding an if statement after the special cases for JS and Flutter on L16-21 is the best option here

image

tjleing avatar Sep 14 '22 17:09 tjleing

Need to update the instructions for using pre-built UI components for RN. Currently, it shows the instructions for the pre-built UI components for web platforms. Until we get the new Authenticator for RN, we should show instructions for setting up the old Authenticator. image

chintannp avatar Oct 06 '22 18:10 chintannp

Both of the issues mentioned by @chintannp have been addressed. Can I please get approvals on this PR now? @chintannp @rachelnabors

abdallahshaban557 avatar Oct 11 '22 05:10 abdallahshaban557

@chintannp - I have resolved your new comments! Please let me know if there is anything else for me to fix!

abdallahshaban557 avatar Oct 12 '22 05:10 abdallahshaban557