aws-sdk-ios icon indicating copy to clipboard operation
aws-sdk-ios copied to clipboard

Published 20 hours ago • verified publisher icon aws-amplify

AWSS3TransferUtility: added MD5 content verification for multi-part uploads

Open MarnixArnold opened this issue 3 years ago • 1 comments

Issue #, if available: Multi-part uploads do not have the option to use content verification by MD5 hash, the way single-part uploads do.

Description of changes:

  • Transfer Utility can now generate and add Content-MD5 headers for the part uploads.
  • Added bool property to multipart upload expression to specify if Content-MD5 headers should be used.

Check points:

  • [X] Added new tests to cover change, if needed
  • [X] All unit tests pass
  • [x] All integration tests pass
  • [X] Updated CHANGELOG.md
  • [ ] Documentation update for the change if required
  • [ ] PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

MarnixArnold avatar Jun 01 '21 16:06 MarnixArnold

@MarnixArnold Thanks for this PR. We are currently working on improvements to AWS S3 support which will include checksum support.

brennanMKE avatar Oct 04 '21 18:10 brennanMKE

Any updates? I would appreciate this feature in the official pod

Ketkukelmi avatar Nov 11 '22 09:11 Ketkukelmi

@MarnixArnold Can you update the PR with the base branch?

harsh62 avatar Mar 07 '23 15:03 harsh62

Hi @MarnixArnold, we had some issue with the CI build script. Could you kindly sync with the main branch one more time?

5d avatar Mar 24 '23 16:03 5d

Hi @5d and @harsh62, the PR is synched with the main branch and it looks like all checks have passed.

MarnixArnold avatar Apr 11 '23 13:04 MarnixArnold

@MarnixArnold The base branch goes out of date really quickly because of the changes we keep pushing and we don't have the permission to update the branch because of it being in a separate repo. Would you be able to create a branch in aws-sdk-ios and open a new PR linking this one to that. It would be really nice. If not, please reach out to me on Discord (harsh62#6655) and we can coordinate getting this PR merged.

harsh62 avatar May 12 '23 19:05 harsh62

Sorry @harsh62, I'm not sure I understand what you mean. Do you want me to create a branch on the aws-sdk-ios repo? I don't have the permissions to do that.

If you make a branch for me on aws-sdk-ios I could aim this PR at that, instead of at main. Then you could update that branch whenever you want. Would that work?

MarnixArnold avatar May 22 '23 16:05 MarnixArnold

Sorry @harsh62, I'm not sure I understand what you mean. Do you want me to create a branch on the aws-sdk-ios repo? I don't have the permissions to do that.

@MarnixArnold You should have permission to create a branch from main and create a PR towards main?

harsh62 avatar May 23 '23 15:05 harsh62

@harsh62 again, I may be misunderstanding you but I really cannot create branches on the aws-sdk-ios repo:

git checkout -b feature/ContentMD5forMultiPartUpload
git push --set-upstream origin feature/ContentMD5forMultiPartUpload
remote: Permission to aws-amplify/aws-sdk-ios.git denied to MarnixArnold.
fatal: unable to access 'https://github.com/aws-amplify/aws-sdk-ios.git/': The requested URL returned error: 403

MarnixArnold avatar May 24 '23 11:05 MarnixArnold

@awsmobilesdk So is anything going to happen with this PR? It's been over two years... We're still using our fork in our projects but it would be nice to be able to switch to the binary distribution using SPM.

MarnixArnold avatar Oct 13 '23 09:10 MarnixArnold