amplify-ui icon indicating copy to clipboard operation
amplify-ui copied to clipboard

chore(react): update react & react-dom types pre-react 19

Open calebpollman opened this issue 1 year ago • 1 comments

Description of changes

Update @types/react and @types/react-dom to ensure compatibility with react@19

Issue #, if available

NA

Description of how you validated changes

yarn lint && yarn build

Checklist

  • [x] Have read the Pull Request Guidelines
  • [x] PR description included
  • [x] yarn test passes and tests are updated/added
  • [x] PR title and commit messages follow conventional commit syntax
  • [x] If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

calebpollman avatar Sep 24 '24 00:09 calebpollman

🦋 Changeset detected

Latest commit: 52c4865e57730db7f5a1fbf5e1943880970faaf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@aws-amplify/ui-react Patch
@aws-amplify/ui-react-ai Patch
@aws-amplify/ui-react-core Patch
@aws-amplify/ui-react-core-notifications Patch
@aws-amplify/ui-react-geo Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-native Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-react-auth Patch
@aws-amplify/ui-react-core-auth Patch
@aws-amplify/ui-react-native-auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 24 '24 00:09 changeset-bot[bot]

What's remaining to get this merged? Getting React 19 support will be a great change.

richardaday avatar Dec 17 '24 19:12 richardaday

I'm still seeing older versions of dependencies that don't support React 19:

morganney@macos openai-realtime (feat/amplify-authn) $ npm ls react-dom
[email protected] /Users/morganney/code/openai-realtime
└─┬ [email protected] -> ./packages/ui
  ├─┬ @aws-amplify/[email protected]
  │ ├─┬ @radix-ui/[email protected]
  │ │ ├─┬ @radix-ui/[email protected]
  │ │ │ ├─┬ @radix-ui/[email protected]
  │ │ │ │ └── [email protected] deduped
  │ │ │ ├─┬ @radix-ui/[email protected]
  │ │ │ │ └── [email protected] deduped
  │ │ │ ├─┬ @radix-ui/[email protected]
  │ │ │ │ ├─┬ @floating-ui/[email protected]
  │ │ │ │ │ └── [email protected] deduped
  │ │ │ │ ├─┬ @radix-ui/[email protected]
  │ │ │ │ │ └── [email protected] deduped
  │ │ │ │ └── [email protected] deduped
  │ │ │ ├─┬ @radix-ui/[email protected]
  │ │ │ │ └── [email protected] deduped
  │ │ │ ├─┬ @radix-ui/[email protected]
  │ │ │ │ └── [email protected] deduped
  │ │ │ ├─┬ @radix-ui/[email protected]
  │ │ │ │ └── [email protected] deduped
  │ │ │ └── [email protected] deduped
  │ │ ├─┬ @radix-ui/[email protected]
  │ │ │ └── [email protected] deduped
  │ │ └── [email protected] deduped
  │ ├─┬ @radix-ui/[email protected]
  │ │ ├─┬ @radix-ui/[email protected]
  │ │ │ └── [email protected] deduped
  │ │ └── [email protected] deduped
  │ └── [email protected]
  ├── [email protected]
  └─┬ [email protected]
    └── [email protected] deduped

When running npm install you'll see npm warn ERESOLVE overriding peer dependency.

I'm running:

morganney@macos openai-realtime (feat/amplify-authn) $ node -v
v22.12.0
morganney@macos openai-realtime (feat/amplify-authn) $ npm -v
10.9.0 

morganney avatar Dec 28 '24 15:12 morganney