amplify-ui icon indicating copy to clipboard operation
amplify-ui copied to clipboard

chore(Authenticator web): Default to lowercase form fields

Open esauerbo opened this issue 1 year ago • 1 comments

Description of changes

iOS safari was defaulting to uppercase first letter for authenticator form fields. This changes the default to lowercase for text and password fields in web authenticator components.

Issue #, if available

fixes #5025

Description of how you validated changes

Checklist

  • [ ] Have read the Pull Request Guidelines
  • [ ] PR description included
  • [ ] Relevant documentation is changed or added (and PR referenced)
  • [ ] yarn test passes and tests are updated/added
  • [ ] No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

esauerbo avatar Feb 22 '24 23:02 esauerbo

⚠️ No Changeset found

Latest commit: e8c0ed353ffe03a4fe5f3c04060a2e2c4ded606f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 22 '24 23:02 changeset-bot[bot]

LGTM, just curious why we don't need to do anything for React Native?

I thought the context for this was a problem with Safari users so I just updated the web components. But I can update RN as well if we think it would have the same issue? @calebpollman

esauerbo avatar Feb 27 '24 18:02 esauerbo

LGTM, just curious why we don't need to do anything for React Native?

I thought the context for this was a problem with Safari users so I just updated the web components. But I can update RN as well if we think it would have the same issue? @calebpollman

MSTM. Let's just quickly verify if RN would benefit from the change before we make it

calebpollman avatar Feb 27 '24 18:02 calebpollman