amplify-ui icon indicating copy to clipboard operation
amplify-ui copied to clipboard

custom primitives

Open vogues opened this issue 2 years ago • 1 comments

On which framework/platform would you like to see this feature implemented?

React

Which UI component is this feature-request for?

Other

Please describe your feature-request in detail.

The current ui kit is very lacking

Please describe a solution you'd like.

Would appreciate the ability to make custom primitives and have easier access to components like tabs and icons. The library is very incomplete.

We love contributors! Is this something you'd be interested in working on?

  • [ ] 👋 I may be able to implement this feature request.
  • [ ] ⚠️ This feature might incur a breaking change.

vogues avatar Jul 30 '22 07:07 vogues

Hi @vogues, What components do you feel are missing? We have Tabs and Icons here: https://ui.docs.amplify.aws/react/components/tabs https://ui.docs.amplify.aws/react/components/icon

Our Icon component is meant to support custom icons. For a full iconset we recommend using one of the many React icon libraries available.

We are working on prioritizing the next UI components we should build and are interested to hear any feedback on what is still missing.

reesscot avatar Aug 01 '22 17:08 reesscot

@vogues We are investing our engineering capacity currently on building more React primitives, please let us know which primitives would you like us to build next. As @reesscot mentioned, we already have tabs and icon primitive available.

Milan-Shah avatar Sep 30 '22 14:09 Milan-Shah

Those suggestions were the main ones I was hoping to see ported to Figma, I may have made a typo when submitting. At any rate, I can see how development goes on my end and make recommendations on the react side as I progress. I appreciate the response.

@vogues We are investing our engineering capacity currently on building more React primitives, please let us know which primitives would you like us to build next. As @reesscot mentioned, we already have tabs and icon primitive available.

vogues avatar Oct 01 '22 02:10 vogues

@vogues Have you seen that it's currently possible to use custom icons in Figma? You can create any custom icon using the Icon component by providing the pathData.

Would also be interested to hear whether you have come up with a list of which additional primitives you'd like to see in Amplify UI.

reesscot avatar Dec 23 '22 20:12 reesscot

There are three things that could be addressed here:

  1. Documentation and ability to create a custom primitive in code. (how would theming work for example)
  2. The ability to create custom primitives in Figma that get codegen’d
  3. Adding the more complex primitives into our Figma file that get codegen’d

reesscot avatar May 22 '23 23:05 reesscot