amplify-swift icon indicating copy to clipboard operation
amplify-swift copied to clipboard

Published 20 hours ago • verified publisher icon aws-amplify

Analytics rename `identityId` parameter to `userId`

Open lawmicha opened this issue 4 years ago • 2 comments

https://github.com/aws-amplify/amplify-ios/blob/64c5ad75e4591278a1769690757b79074e9c38a8/Amplify/Categories/Analytics/AnalyticsCategoryBehavior.swift#L18

lawmicha avatar May 20 '20 00:05 lawmicha

Should the change be only made to AnalyticsCategoryBehavior.swift and AnalyticsCategory+ClientBehavior.swift from the Amplify/Categories/Analytics category or should it also include files from the AWSPinpointAnalyticsPlugin project as well?

raheel avatar Jan 15 '21 04:01 raheel

Hi @raheel, yes this should be done at the category level and at the plugin's implementation. Since this requires some cordination across platforms for the category change and since it's also a breaking change, i'm going to remove this as a good first issue and mark it under milestone 2.0.0

lawmicha avatar Jul 08 '21 15:07 lawmicha

Released in v2.0.0

royjit avatar Oct 20 '22 01:10 royjit