amplify-swift icon indicating copy to clipboard operation
amplify-swift copied to clipboard

feat(API): implement AppSyncRealTimeClient and WebSocketClient with URLSession

Open 5d opened this issue 1 year ago • 1 comments

Issue #

Description

General Checklist

  • [x] Added new tests to cover change, if needed
  • [x] Build succeeds with all target using Swift Package Manager
  • [x] All unit tests pass
  • [x] All integration tests pass
  • [ ] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • [x] Documentation update for the change if required
  • [x] PR title conforms to conventional commit style
  • [ ] New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • [ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

5d avatar Feb 16 '24 00:02 5d

Codecov Report

Attention: Patch coverage is 74.53110% with 258 lines in your changes are missing coverage. Please review.

Project coverage is 68.35%. Comparing base (358699c) to head (ec4519f).

Files Patch % Lines
.../AppSyncRealTimeClient/AppSyncRealTimeClient.swift 59.65% 94 Missing :warning:
...r/SubscriptionInterceptor/IAMAuthInterceptor.swift 0.00% 38 Missing :warning:
...ore/AWSPluginsCore/WebSocket/WebSocketClient.swift 84.11% 27 Missing :warning:
...criptionFactory/AppSyncRealTimeClientFactory.swift 70.58% 25 Missing :warning:
...n/Operation/AWSGraphQLSubscriptionTaskRunner.swift 88.70% 14 Missing :warning:
...meClient/AppSyncRealTimeClient+HandleRequest.swift 80.00% 13 Missing :warning:
...ncRealTimeClient/AppSyncRealTimeSubscription.swift 77.19% 13 Missing :warning:
Amplify/Core/Support/JSONValue.swift 68.96% 9 Missing :warning:
...bscriptionInterceptor/CognitoAuthInterceptor.swift 82.05% 7 Missing :warning:
...SPluginsCore/WebSocket/AmplifyNetworkMonitor.swift 61.11% 7 Missing :warning:
... and 5 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feat/url-session-web-socket-task    #3527      +/-   ##
====================================================================
- Coverage                             68.47%   68.35%   -0.13%     
====================================================================
  Files                                  1077     1084       +7     
  Lines                                 36282    36927     +645     
====================================================================
+ Hits                                  24844    25241     +397     
- Misses                                11438    11686     +248     
Flag Coverage Δ
API_plugin_unit_test 67.80% <71.91%> (+0.30%) :arrow_up:
AWSPluginsCore 68.70% <84.09%> (+1.80%) :arrow_up:
Amplify 48.21% <70.96%> (+0.09%) :arrow_up:
Analytics_plugin_unit_test 81.16% <ø> (ø)
Auth_plugin_unit_test 79.01% <ø> (-0.11%) :arrow_down:
CoreMLPredictions_plugin_unit_test 59.44% <ø> (ø)
DataStore_plugin_unit_test 81.37% <ø> (-1.09%) :arrow_down:
Geo_plugin_unit_test 70.75% <ø> (ø)
Logging_plugin_unit_test 62.87% <ø> (ø)
Predictions_plugin_unit_test 37.16% <ø> (ø)
PushNotifications_plugin_unit_test 87.13% <ø> (ø)
Storage_plugin_unit_test 77.61% <ø> (ø)
unit_tests 68.35% <74.53%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 16 '24 00:02 codecov-commenter