amplify-swift icon indicating copy to clipboard operation
amplify-swift copied to clipboard

chore(datastore): update PR template with checkpoints

Open lawmicha opened this issue 3 years ago • 1 comments

Issue #, if available:

Description of changes: similar reminder on dev-preview https://github.com/aws-amplify/amplify-ios/pull/2393

Check points: (check or cross out if not relevant)

  • [ ] Added new tests to cover change, if needed
  • [ ] Build succeeds with all target using Swift Package Manager
  • [ ] All unit tests pass
  • [ ] All integration tests pass
  • [ ] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • [ ] Documentation update for the change if required
  • [ ] PR title conforms to conventional commit style
  • [ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lawmicha avatar Oct 05 '22 03:10 lawmicha

Codecov Report

Merging #2394 (5f778cd) into main (6672b2a) will increase coverage by 0.04%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
+ Coverage   63.96%   64.01%   +0.04%     
==========================================
  Files         720      720              
  Lines       22633    22633              
==========================================
+ Hits        14478    14489      +11     
+ Misses       8155     8144      -11     
Flag Coverage Δ
API_plugin_unit_test 66.66% <ø> (ø)
AWSPluginsCore 73.30% <ø> (-0.08%) :arrow_down:
Amplify 51.32% <ø> (+0.05%) :arrow_up:
Analytics_plugin_unit_test 72.72% <ø> (ø)
Auth_plugin_unit_test 81.94% <ø> (ø)
DataStore_plugin_unit_test 81.63% <ø> (+0.14%) :arrow_up:
Geo_plugin_unit_test 57.87% <ø> (ø)
Predictions_plugin_unit_test 33.53% <ø> (ø)
Storage_plugin_unit_test 59.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Plugin/Sync/Support/MutationEvent+Extensions.swift 23.80% <0.00%> (-45.24%) :arrow_down:
...e/AWSPluginsCore/Auth/AWSAuthServiceBehavior.swift 75.00% <0.00%> (-12.50%) :arrow_down:
...oreCategoryPlugin/Sync/Support/Model+Compare.swift 82.29% <0.00%> (+2.08%) :arrow_up:
...s/AWSHubPlugin/Internal/HubChannelDispatcher.swift 94.11% <0.00%> (+8.82%) :arrow_up:
...MutationQueue/OutgoingMutationQueue+Resolver.swift 92.85% <0.00%> (+10.71%) :arrow_up:
...ngMutationQueue/OutgoingMutationQueue+Action.swift 66.66% <0.00%> (+66.66%) :arrow_up:
...ingMutationQueue/OutgoingMutationQueue+State.swift 68.75% <0.00%> (+68.75%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 05 '22 03:10 codecov-commenter