amplify-swift icon indicating copy to clipboard operation
amplify-swift copied to clipboard

Property 'identifier' must be declared public because it matches a requirement in public protocol 'Model'

Open atierian opened this issue 3 years ago • 1 comments

Describe the bug

Updating from 1.24.0 to 1.28.1 surfaces compiler error Property 'identifier' must be declared public because it matches a requirement in public protocol 'Model'

See https://github.com/aws-amplify/aws-sdk-ios/issues/4327 for more context.

Amplify Framework Version

1.28.1

Amplify Categories

API, DataStore

Dependency manager

Cocoapods

Swift version

5.7

CLI version

Xcode version

14

Is this a regression?

Yes

Regression additional context

No response

atierian avatar Sep 23 '22 14:09 atierian

This issue was opened by a maintainer of this repository; updates will be posted here. If you are also experiencing this issue, please comment here with any relevant information so that we're aware and can prioritize accordingly.

github-actions[bot] avatar Sep 23 '22 14:09 github-actions[bot]

I couldn't find much more context about the error in the linked error. @dsaliberti are you still blocked by this? Do you have more details on the issue such as which file is failing to compile? For reference, the identifier property of Model is defined here

lawmicha avatar Nov 01 '22 14:11 lawmicha

@lawmicha Thanks for the feedback, I'm definitely not blocked and we've bumped to the mentioned version and dropped our custom fork as we needed add timezone support and that's already in place ✨ ~I'll close~ this one can be closed 👍 thanks again

dsaliberti avatar Nov 01 '22 15:11 dsaliberti