amplify-swift icon indicating copy to clipboard operation
amplify-swift copied to clipboard

In a multipart upload using Amplify.Storage.uploadFile, pre-signed URLs for each part should have 50 minute expiration from the time that each part is created instead of the time from which the first part is created

Open sagarjoshi opened this issue 3 years ago • 7 comments

Is your feature request related to a problem? Please describe.

I am hoping that this is a smaller fix than re-thinking the entire approach ( https://github.com/aws-amplify/amplify-ios/discussions/1740 ) which includes this idea + background uploads. Some of my users with poor upload bandwidth are running into timeout issues for large files.

Describe the solution you'd like

in the title :)

Describe alternatives you've considered

long discussion here around longer term approach ( https://github.com/aws-amplify/amplify-ios/discussions/1740 )

Is the feature request related to any of the existing Amplify categories?

Storage

Additional context

No response

sagarjoshi avatar May 28 '22 21:05 sagarjoshi

@brennanMKE FYI

sagarjoshi avatar May 28 '22 21:05 sagarjoshi

Also , I am assuming that all the parts are not created at once. If they are then feel free to redo the bug.

sagarjoshi avatar May 29 '22 04:05 sagarjoshi

The way the SDK works has been this way for many years. The new Swift SDK will create the pre-signed URL just as the upload for a part is about to start, so it has the behavior that would handle the timeout better. If you'd like this update in the SDK please create a feature request. We are working on the Dev Preview for the new Amplify GA release which you may find will include many improvements that you want.

brennanMKE avatar Jun 03 '22 17:06 brennanMKE

@sagarjoshi WWDC starts Monday and I will try to get a lab session to discuss this issue.

https://github.com/aws-amplify/amplify-ios/discussions/1740

brennanMKE avatar Jun 03 '22 17:06 brennanMKE

sorry, somehow I missed this. I thought https://github.com/aws-amplify/amplify-ios/issues/1838 was the feature request.

Also please let us know the result of the discussion for https://github.com/aws-amplify/amplify-ios/discussions/1740

sagarjoshi avatar Jun 10 '22 22:06 sagarjoshi

Hi ! Can this please be patched in the existing amplify library ? My users in Asia simply cannot upload large videos without getting timed out and starting all over again ( and failing again ) .

sagarjoshi avatar Jun 16 '22 21:06 sagarjoshi

@brennanMKE at-least this way it will take whatever it takes but actually finish .

sagarjoshi avatar Jun 16 '22 21:06 sagarjoshi

This has been identified as a feature request. If this feature is important to you, we strongly encourage you to give a 👍 reaction on the request. This helps us prioritize new features most important to you. Thank you!

github-actions[bot] avatar Nov 21 '22 23:11 github-actions[bot]

Definitely need this

sagarjoshi avatar Nov 22 '22 00:11 sagarjoshi

Cannot reliably upload large files without this

sagarjoshi avatar Nov 22 '22 00:11 sagarjoshi

@sagarjoshi we recently made improvements to speed at which uploads complete. Please see this comment for more information https://github.com/aws-amplify/amplify-swift/issues/1542#issuecomment-1533006240 and let us know if updating resolves your issue. Thanks!

atierian avatar May 03 '23 13:05 atierian