amplify-studio icon indicating copy to clipboard operation
amplify-studio copied to clipboard

Buttons with icons not exported correctly from Figma into Amplify Studio

Open olliethedev opened this issue 2 years ago • 5 comments

Before opening, please confirm:

  • [X] I have searched for duplicate or closed issues.
  • [X] I have read the guide for submitting bug reports.
  • [X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
  • [X] I have removed any sensitive information from my code snippets and submission.

App Id

d1eiid2wdqi1eb

Region

us-east-1

Environment name

staging

Figma File Version (if applicable)

1.2.0

Amplify CLI Version

10.5.1

If applicable, what version of Node.js are you using?

v19.1.0

What operating system are you using?

Mac

Browser type?

Google Chrome

Describe the bug

I am having issues with importing Figma designs with Buttons that have Icons defined.

Screen Shot 2022-11-30 at 1 20 22 PM Screen Shot 2022-11-30 at 1 21 00 PM If I use Icon variant built into the Button primitive, the Button is rendered in React but no children are present, and if I change the Icon primitive to my own svg in figma, then the component renders as
instead of Button.

Expected behavior

Figma design should correctly import and a <Button/> Element should render with correct <Icon/> component.

Reproduction steps

  1. Clone AWS-Amplify-UI-Kit Figma project.
  2. In Figma create a button set the Button Icon to any Icon variant.
  3. Import into Amplify Studio
  4. The Icon will be missing if using Icon primitve.

===or====

  1. Clone AWS-Amplify-UI-Kit Figma project.
  2. In Figma create a button set the Button Icon to a custom SVG image.
  3. Import into Amplify Studio
  4. The button will be a
    if using a custom svg for icon.

Project Identifier

No response

Additional information

No response

olliethedev avatar Dec 01 '22 01:12 olliethedev

Hey @olliethedev, thank you for reaching out. The icon buttons from the AWS-Amplify-UI-Kit Figma project have been deprecated. We do not currently support importing buttons with icons for example svg inside a primitive. We will work on cleaning up the deprecated icons from the Figma UI kit. Thank you for reporting this.

ykethan avatar Dec 07 '22 18:12 ykethan

Wasted 3 days for this. I think It needs it very much. Most of mobile buttons with an icon or only an icon.

noma6386-duplicate avatar Mar 31 '23 04:03 noma6386-duplicate

Yea, I've wasted too much time on this as well. I think I'm done with all this..

JimW avatar May 02 '23 04:05 JimW

Its now Jan 2024 and the comment from Dec 2022 "We will work on cleaning up the deprecated icons from the Figma UI kit" is still not implemented. I too wasted time on this.

vtreanor avatar Jan 19 '24 12:01 vtreanor

I've also found this confusing, any updates on when they will be removed?

MitchellNeill avatar Jun 15 '24 01:06 MitchellNeill