refactor(amazon-cognito-identity-js): refactor issue 8969 better typings

[Yoshiitaka]

Issue #https://github.com/aws-amplify/amplify-js/issues/8969,

Better type definitions for amazon-cognito-identity-js.

Checklist

• [x] PR description included

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[ShawnCockburn]

+1

[chintannp]

Hey @Yoshiitaka , Thanks for your contribution to the AWS Amplify JS Library. We are actively reviewing your PR and will provide feedback soon if needed.

[chintannp]

@Yoshiitaka , I won't be able fix the merge conflict as your forked branch is behind. Can you fix the merge conflicts so that we can review the PR and be able to merge it?

[Yoshiitaka]

@chintannp Thank you check this PR. I updated the forked branch and fixed the conflicts part :) Please Could you review this PR?

[chintannp]

@Yoshiitaka, In order to get this change out quickly, Can you please review and address the feedback provided by @elorzafe ?

[Yoshiitaka]

@elorzafe Thank you for reviewing. This PR was dealt with a long time ago, So I will check the points to be pointed out and corrections from now.

Certainly, I was understood that the token payload may break the mold as you pointed out.

[Yoshiitaka]

@chintannp Sorry for the late confirmation and reply. I will check the review pointed out from this and correct it.

[chintannp]

@Yoshiitaka , Can you address the feedback provide by @elorzafe ?

[Yoshiitaka]

@chintannp I have already responded to @elorzafe 's feedback comment, So Please could you check it?

[codecov-commenter]

Codecov Report

Merging #9935 (e463eda) into main (91fdcd9) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9935   +/-   ##
=======================================
  Coverage   84.40%   84.40%           
=======================================
  Files         258      258           
  Lines       18698    18698           
  Branches     4021     4021           
=======================================
  Hits        15782    15782           
  Misses       2826     2826           
  Partials       90       90           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[aminya]

When I use Hub.listen and get the payload.data, the found CognitoUser doesn't have any methods. That's because it is serialized. So, the properties should be still added. The getters are not enough.