aws-amplify
ConsoleLogger: bind console.debug for logger.debug
Description of changes
Issue #, if available
- Current behavior: When using consoleLogger.debug,
console.logis used under the hood. - Issue: this causes chrome devtool's log filtering function not work. During development I usually turned on all log level in ConsoleLogger and use Chrome devtool to filter logs.
- Solution: bind
console.debug
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Hey, @sjdeak 👋. Apologies for the delayed response on this PR, but thank you for your contribution! We're going to be testing this PR and considering it for merging, so we'll follow up with any questions or updates very soon. Thank you for your patience.
@ashwinkumar6 Let me know your suggestion to this change, willing to contribute.
Thanks! It's traditional festival in my country will soon response once when I'm back to work.
Hey @sjdeak, We're performing some additional validations from our side, Thank you for your patience.
Hi @ashwinkumar6 @ashika112 , has addressed comments and fixed the failed test case(also verified locally), please check, thanks.
@sjdeak Thanks, I think we would also need to update the bundle size a bit, we can take it forward from here
@sjdeak Thanks, I think we would also need to update the bundle size a bit, we can take it forward from here
Hi @ashwinkumar6 also just updated the bundle-size in my side, , let's see the CI result 😉, but please take over the rest work and feel free to make modification.
Hi @ashwinkumar6 could we merge the PR in next week? Really looking forward to see a cleaner console log when using Amplify, thanks!
Thanks for your patience @sjdeak. We're exploring making this update an opt-in feature to avoid any breaking changes, For example we could introduce a property to toggle for users to enable at their discretion. I'm currently away and will be back in a week. Once I return, I'll work on finalizing this approach.