amplify-js icon indicating copy to clipboard operation
amplify-js copied to clipboard

fix: kinesis analytics event type

Open bokuweb opened this issue 2 years ago • 1 comments

Description of changes

It seems that partitionKey in KinesisAnalyticsEvent should be optional?

Issue #, if available

Description of how you validated changes

Checklist

  • [x] PR description included
  • [ ] yarn test passes
  • [ ] Tests are changed or added
  • [ ] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

bokuweb avatar Mar 31 '23 04:03 bokuweb

It seems that partitionKey in KinesisAnalyticsEvent should be optional?

Can you provide more information about why it should be optional? Do you have any sample code? Are you encountering a problem that this change resolves?

stocaaro avatar Apr 14 '23 17:04 stocaaro

@bokuweb, wanted to follow up on this PR to see if we can get more context. It looks like the Partition Key is required per the Amazon Kinesis docs. Is there a scenario where you'd need this to be optional? Thanks.

cwomack avatar Sep 17 '24 20:09 cwomack

Closing this PR as we have not heard back from you. Please feel free to reply back and provide any information previously requested and we'd be happy to re-open.

Thank you!

cwomack avatar Nov 12 '24 21:11 cwomack