amplify-js icon indicating copy to clipboard operation
amplify-js copied to clipboard

feat(@aws-amplify/storage): pagination for storage list api using Token

Open kvramyasri7 opened this issue 3 years ago • 2 comments

Description of changes

To enable users to paginate through storage using List api. Enabled users to pass a pageToken to the list Api so that they can get a next set of files.

Issue #, if available

#7133 #6838

Description of how you validated changes

  • Unit test added for the change
  • Tested change in the sample app

Checklist

  • [X] PR description included
  • [X] yarn test passes
  • [ ] Tests are changed or added
  • [ ] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kvramyasri7 avatar Aug 05 '22 00:08 kvramyasri7

Codecov Report

Merging #10161 (b2f49ec) into next-major-version/5 (fd653f8) will decrease coverage by 0.00%. The diff coverage is 92.00%.

@@                   Coverage Diff                    @@
##           next-major-version/5   #10161      +/-   ##
========================================================
- Coverage                 84.27%   84.27%   -0.01%     
========================================================
  Files                       255      255              
  Lines                     18522    18531       +9     
  Branches                   3980     3983       +3     
========================================================
+ Hits                      15610    15617       +7     
- Misses                     2822     2824       +2     
  Partials                     90       90              
Impacted Files Coverage Δ
packages/core/src/Signer.ts 89.39% <66.66%> (+0.16%) :arrow_up:
packages/storage/src/providers/AWSS3Provider.ts 90.90% <95.45%> (-0.43%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Aug 05 '22 01:08 codecov-commenter

This pull request introduces 1 alert when merging b3906dcf6ab60668dedf54d3fd636cef5c977793 into a6936953c9f4660a7e315395e3a0fc8d4b2a75fb - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Aug 05 '22 17:08 lgtm-com[bot]

Closing this PR and opened a new PR with the pagination changes.

kvramyasri7 avatar Aug 10 '22 21:08 kvramyasri7