amplify-js
amplify-js copied to clipboard
Update Errors.ts
Change 'AuthError' for type of error. Otherwise the error type is overwrited with 'AuthError' and this makes that becames imposible to translate error messages based on error code in the client.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Codecov Report
Merging #10115 (5c0dbc7) into main (de0441b) will increase coverage by
0.01%
. The diff coverage is91.54%
.
@@ Coverage Diff @@
## main #10115 +/- ##
==========================================
+ Coverage 84.12% 84.14% +0.01%
==========================================
Files 253 253
Lines 18263 18287 +24
Branches 3918 3923 +5
==========================================
+ Hits 15364 15387 +23
- Misses 2809 2810 +1
Partials 90 90
Impacted Files | Coverage Δ | |
---|---|---|
packages/analytics/src/Analytics.ts | 62.92% <ø> (ø) |
|
packages/api-graphql/src/types/index.ts | 100.00% <ø> (ø) |
|
packages/datastore/src/types.ts | 81.29% <ø> (ø) |
|
...ages/datastore/src/sync/processors/subscription.ts | 73.58% <72.72%> (+0.02%) |
:arrow_up: |
packages/datastore/src/sync/processors/mutation.ts | 74.75% <85.71%> (+0.25%) |
:arrow_up: |
packages/datastore/src/datastore/datastore.ts | 83.82% <90.90%> (+0.23%) |
:arrow_up: |
...astore/src/authModeStrategies/multiAuthStrategy.ts | 92.75% <91.66%> (ø) |
|
packages/api-graphql/src/GraphQLAPI.ts | 87.76% <100.00%> (+0.26%) |
:arrow_up: |
packages/auth/src/Errors.ts | 100.00% <100.00%> (ø) |
|
packages/core/src/Platform/index.ts | 77.77% <100.00%> (ø) |
|
... and 4 more |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
Hi @cargallo - we are in the middle of re-writing our Auth category including providing better type support. This change has been noted internally on our end, and we will address it as part of our refactor. I am closing this PR for now - thank you for your contribution!