amplify-codegen-ui icon indicating copy to clipboard operation
amplify-codegen-ui copied to clipboard

fix: clear form field errors on cancel

Open jacoblogan opened this issue 11 months ago • 1 comments

Problem

Required field error not being cleared when cancelling input

Solution

On cancel clear form field errors

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • [ ] Unit tests added/updated
  • [ ] E2E tests added/updated
  • [ ] N/A - (provide a reason)
  • [ ] deferred - (provide GitHub issue for tracking)

Housekeeping

  • [ ] No non-essential console logs
  • [ ] All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jacoblogan avatar Mar 14 '24 15:03 jacoblogan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.86%. Comparing base (70799cb) to head (acf92ac).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1157   +/-   ##
=======================================
  Coverage   93.86%   93.86%           
=======================================
  Files         150      150           
  Lines        6114     6114           
  Branches     1838     1838           
=======================================
  Hits         5739     5739           
  Misses        357      357           
  Partials       18       18           
Files Coverage Δ
...-ui-react/lib/utils/forms/array-field-component.ts 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70799cb...acf92ac. Read the comment docs.

codecov-commenter avatar Mar 14 '24 15:03 codecov-commenter