amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

feat: add console open support for S3 storage buckets

Open gpoul opened this issue 4 years ago • 5 comments

Description of changes

Added console open support for S3 storage bucket; before this change it would just display "to be implemented..."; one of our participants ran into this during an Amplify Photo Sharing Workshop.

Description of how you validated changes

Tested in an empty amplify project before & after adding a storage component.

Checklist

  • [X] PR description included
  • [X] yarn test passes
  • No tests are changed or added; if required it would be great if you could point me to another console test I can review to build it
  • No Relevant documentation is changed or added (and PR referenced)
  • No New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

gpoul avatar Feb 04 '22 20:02 gpoul

Codecov Report

Merging #9708 (01ff80f) into master (bc57ed2) will decrease coverage by 0.02%. The diff coverage is 7.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9708      +/-   ##
==========================================
- Coverage   52.99%   52.96%   -0.03%     
==========================================
  Files         830      830              
  Lines       45993    46021      +28     
  Branches     9824     9830       +6     
==========================================
+ Hits        24373    24375       +2     
- Misses      19602    19628      +26     
  Partials     2018     2018              
Impacted Files Coverage Δ
...udformation/service-walkthroughs/s3-walkthrough.ts 71.59% <5.88%> (-3.49%) :arrow_down:
...rage/src/provider-utils/awscloudformation/index.ts 13.04% <9.09%> (-0.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bc57ed2...01ff80f. Read the comment docs.

codecov-commenter avatar Feb 04 '22 21:02 codecov-commenter

Hi @gpoul, thanks for the contribution! Are you still interested in working on this?

danielleadams avatar Jun 27 '22 20:06 danielleadams

Hi @gpoul, thanks for the contribution! Are you still interested in working on this?

There's a lot going on the last weeks; If it is fine for you I'll follow-up mid August unless someone else has progressed it until then, but I won't have time before that. I'm still motivated to do it, though.

gpoul avatar Jun 28 '22 14:06 gpoul

Hey @gpoul - just following up here. Are you still interested in moving this forward?

danielleadams avatar Sep 01 '22 14:09 danielleadams

@danielleadams I've now applied most of the feedback and followed up on one open point that still needs to be addressed

gpoul avatar Sep 05 '22 13:09 gpoul

@jhockett would you be able to look at this again? No real changes other than what you requested and me squashing the commits to make the history clean

gpoul avatar Sep 22 '22 08:09 gpoul

Hi @gpoul, I'm very sorry for the late reply, somehow I missed your ping back in September.

#10981 adds the same feature as this PR. Since 10981 includes unit tests and adds the console command for both S3 and DDB, I'm going to close this PR as a duplicate. We appreciate your contribution nonetheless!

jhockett avatar Dec 27 '22 22:12 jhockett