push proceeds even if custom resource build fails

[attilah]

Before opening, please confirm:

• [X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
• [X] I have searched for duplicate or closed issues.
• [X] I have read the guide for submitting bug reports.
• [X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?

npm

If applicable, what version of Node.js are you using?

14

Amplify CLI Version

7.x

What operating system are you using?

macos

Amplify Categories

Not applicable

Amplify Commands

push

Describe the bug

When the typescript compilation fails for custom resources push still proceed (and fail)

Expected behavior

Don't proceed with push if compilation failed

Reproduction steps

1. add custom resource
2. modify the TS file to not to compile
3. push

GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information

No response

[kaustavghosh06]

Yes. It shows the error in red with compilation and then asks 'Do you want to proceed? "

[attilah]

And on --yes it proceeds

[garciajg]

I am also having the same issue. Also found that the post-push hook doesn't get triggered

[sobolk]

This has been fixed in @aws-amplify/[email protected]

[github-actions[bot]]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.