amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

feat(amplify-appsync-simulator): add TransactWriteItems support

Open chucre opened this issue 5 years ago • 9 comments

add TransactWriteItems support to DynamoDB operations

Add TransactWriteItems support to amplify-appsync-simulator

Issue #, if available: implement aws-amplify/amplify-category-api#259

Description of changes: Implement the missing TransactWriteItems operator to DynamoDB data loader

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

chucre avatar Oct 13 '20 16:10 chucre

Codecov Report

Merging #5574 into master will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    aws-amplify/amplify-cli#5574    +/-   ##
========================================
  Coverage   59.08%   59.08%            
========================================
  Files         402      402            
  Lines       18043    18043            
  Branches     3575     3388   -187     
========================================
  Hits        10661    10661            
- Misses       6723     6743    +20     
+ Partials      659      639    -20     
Impacted Files Coverage Δ
...ackages/amplify-cli/src/utils/mobilehub-support.ts 39.28% <0.00%> (ø)
...gen-appsync-model-plugin/src/utils/process-auth.ts 100.00% <ø> (ø)
packages/amplify-util-mock/src/api/api.ts 0.00% <0.00%> (ø)
packages/graphql-mapping-template/src/print.ts 34.65% <0.00%> (ø)
packages/amplify-util-mock/src/storage/storage.ts 0.00% <0.00%> (ø)
...ges/amplify-util-mock/src/CFNParser/stack/index.ts 0.00% <0.00%> (ø)
...es/amplify-util-mock/src/api/resolver-overrides.ts 0.00% <0.00%> (ø)
...es/graphql-transformer-core/src/stripDirectives.ts 35.29% <0.00%> (ø)
.../amplify-cli-core/src/state-manager/pathManager.ts 70.42% <0.00%> (ø)
.../amplify-util-mock/src/utils/lambda/loadMinimal.ts 0.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 763f4af...520ebda. Read the comment docs.

codecov[bot] avatar Oct 13 '20 17:10 codecov[bot]

This pull request introduces 1 alert when merging 520ebda13804710ca6212b079d6b714f6c9449c3 into 43eb3e8a307bb320648c5cce87cb21ec10e54b7a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Oct 13 '20 17:10 lgtm-com[bot]

@yuth @jhockett Any idea when this could be merged in?

cheneveld avatar Apr 22 '21 00:04 cheneveld

@yuth Any chance we can move this PR forward?

cheneveld avatar Sep 10 '21 15:09 cheneveld

Dear Amplify team, would it be possible to merge this pull request after 1 year of ignoring it, please?

majirosstefan avatar Oct 24 '21 22:10 majirosstefan

Do I understand it correctly that this pull request has been waiting for over a year without any feedback?? For anyone who builds a complex multi user application it's absolutely essential to be able to run fast tests involving transactions!!

staffanpalopaa avatar Jan 11 '22 03:01 staffanpalopaa

Any news here ? @yuth

a-marcel avatar Jan 02 '23 20:01 a-marcel

Apologies for the delay. Started looking into this PR, only thing missing is testing. Please add some unit tests and if applicable, steps on how the change was tested locally.

Amplifiyer avatar Feb 01 '23 13:02 Amplifiyer

@chucre are you still interested in making this contribution?

danielleadams avatar Apr 26 '23 21:04 danielleadams