amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

improve validation on `sign in with apple` private key

Open ykethan opened this issue 2 years ago • 2 comments

How did you install the Amplify CLI?

No response

If applicable, what version of Node.js are you using?

No response

Amplify CLI Version

12.2.3

What operating system are you using?

mac

Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.

no

Describe the bug

It appears the validation on CLI allows just typing in the begin and end of the private key image (8)

Expected behavior

validate and throw appropriate message

Reproduction steps

  1. add auth
  2. select signin with apple
  3. enter the begin and end without the hash key
  4. observe no errors

Project Identifier

No response

Log output

# Put your logs below this line


Additional information

No response

Before submitting, please confirm:

  • [X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
  • [X] I have removed any sensitive information from my code snippets and submission.

ykethan avatar Aug 03 '23 16:08 ykethan

related https://github.com/aws-amplify/amplify-cli/issues/8097 marking as a feature request

josefaidt avatar Aug 03 '23 16:08 josefaidt

@josefaidt Is this issue still up for fixing?

RamananThiru avatar May 25 '25 06:05 RamananThiru