amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

fix: updateUserAttributeSetting during add/update/push flows

Open akshbhu opened this issue 3 years ago • 3 comments

Description of changes

  • adds attr during amplify add / amplify update flows
  • adds this attr during amplify pull / push / build workflow
  • for console and studio builds , this will work fine as contents are pushed with force
  • for cli Cx , if Cx doesn't update the auth category , it needs a force push to update the userPool with this attribute.

Issue #10561

Description of how you validated changes

  • updated unit tests
  • Manually tested
  • https://app.circleci.com/pipelines/github/aws-amplify/amplify-cli/9793/workflows/f25bee72-b282-451e-a01e-eb673df2c60c

Checklist

  • [x] PR description included
  • [ ] yarn test passes
  • [ ] Tests are changed or added
  • [ ] Relevant documentation is changed or added (and PR referenced)
  • [ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

akshbhu avatar Jul 19 '22 18:07 akshbhu

This pull request introduces 1 alert when merging ba8ff68a982af426ef29cecc7f0363fcaa04b1e7 into c70cc1f9bbb05501804571dee54bd6ee2ead48db - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 19 '22 18:07 lgtm-com[bot]

This pull request introduces 1 alert when merging 12e3785f67aa0d2a2499be5ca39860589ab65e68 into c36fa71f54cdce1fb889560c3254d8f662c03cae - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar Jul 20 '22 11:07 lgtm-com[bot]

@akshbhu this needs a rebase

danielleadams avatar Jul 25 '22 16:07 danielleadams