amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

feat!: hooks are no longer maintained in the s3 bucket

Open lazpavel opened this issue 2 years ago • 2 comments

Description of changes

  • hooks files are no longer maintained in the s3 bucket -- amplify pull no longer downloads and overrides hooks directory -- amplify push / amplify init no longed uploads the hooks directory to the S3 bucket

Issue #10253

Checklist

  • [x] PR description included
  • [x] yarn test passes
  • [x] Tests are changed or added
  • [ ] Relevant documentation is changed or added (and PR referenced)
  • [ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

lazpavel avatar Jun 29 '22 17:06 lazpavel

PR looks good , but when changing env , Do we need to pull hooks from deployment bucket ? Hi @akshbhu, CLI will no longer maintain hook files in the deployment bucket, and we'll let the customer maintain them manually or using their source control

lazpavel avatar Jul 06 '22 19:07 lazpavel

Discussed offline

akshbhu avatar Jul 06 '22 19:07 akshbhu

Using amplifyPush --simple in amplify.yml still overwrites hooks folder with the S3 bucket hooks folder (which doesn't have correct content).

Voyager-Two avatar Oct 05 '22 14:10 Voyager-Two

Hi @Voyager-Two, can you confirm that the Amplify CLI version in the Amplify Hosting build image settings is set to latest? Thank you

lazpavel avatar Oct 05 '22 16:10 lazpavel

@lazpavel Yes it's set to latest, and I've verified with build logs.

Voyager-Two avatar Oct 05 '22 20:10 Voyager-Two

hookissue

david10e avatar Oct 06 '22 04:10 david10e