amplify-cli icon indicating copy to clipboard operation
amplify-cli copied to clipboard

fix: golang function build for goversion above 1.17

Open sky4git opened this issue 3 years ago • 3 comments

Description of changes

Golang version above 1.17 has deprecated go get command and instead suggested to use go install https://go.dev/doc/go-get-install-deprecation To fix the issue in the local environment while working with amplify build function GoFunction -y, we need to change the command to fetch and install the github.com/aws/aws-lambda-go/cmd/build-lambda-zip.

Changes are made to work with golang version above > 1.17 and below it.

Issue #10564

Description of how you validated changes

  • [X] PR description included
  • [X] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sky4git avatar Jun 12 '22 05:06 sky4git

Codecov Report

Merging #10569 (a375cf5) into dev (fb2ba7b) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #10569   +/-   ##
=======================================
  Coverage   47.81%   47.81%           
=======================================
  Files         669      669           
  Lines       32671    32671           
  Branches     6600     6600           
=======================================
+ Hits        15621    15622    +1     
+ Misses      15420    15419    -1     
  Partials     1630     1630           
Impacted Files Coverage Δ
...li/src/domain/amplify-usageData/getUsageDataUrl.ts 100.00% <0.00%> (+12.50%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jun 12 '22 05:06 codecov-commenter

Hi @sky4git, changes LGTM, thank you for your contribution!

pavellazar avatar Jun 14 '22 22:06 pavellazar

@sky4git thanks again for the work here - do you mind rebasing this? Some package names changed and it's breaking the tests.

danielleadams avatar Jul 22 '22 21:07 danielleadams

@sky4git thanks again for the work here - do you mind rebasing this? Some package names changed and it's breaking the tests.

@danielleadams Please check it again.

sky4git avatar Sep 04 '22 13:09 sky4git