amplify-category-api icon indicating copy to clipboard operation
amplify-category-api copied to clipboard

Erroneous rollback message can show "rolling back 2 of 1"

Open johnpc opened this issue 4 years ago • 1 comments

Before opening, please confirm:

  • [X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
  • [X] I have searched for duplicate or closed issues.
  • [X] I have read the guide for submitting bug reports.
  • [X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?

npm

If applicable, what version of Node.js are you using?

14

Amplify CLI Version

7.6

What operating system are you using?

Mac

Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.

n/a

Amplify Categories

Not applicable

Amplify Commands

Not applicable

Describe the bug

In deployment-manager.ts (specifically L147) it is possible for the spinner to get into a state where it says

2022-01-05T03:08:29.838Z [WARNING]: ⠴ Rolling back (2 of 1)

This doesn't make any sense - if there is only one resource to roll back, it can't be rolling back the second one.

Expected behavior

It should stop after

2022-01-05T03:08:29.838Z [WARNING]: ⠴ Rolling back (1 of 1)

completes

Reproduction steps

easiest reproduction would probably be a unit test

GraphQL schema(s)

# Put schemas below this line


Log output

# Put your logs below this line


Additional information

No response

johnpc avatar Jan 14 '22 17:01 johnpc