amplify-android icon indicating copy to clipboard operation
amplify-android copied to clipboard

chore(storage): add integration tests for multi-bucket support

Open phantumcode opened this issue 6 months ago • 0 comments

Multi-bucket support part 4

This the 4th and last part of a series of changes/pull request to support multi-bucket in the S3 Storage Plugin. The series of changes will be reviewed and merged into a feature branch and combined into a single pull request to be reviewed and merged into main branch.

For references: part 1: https://github.com/aws-amplify/amplify-android/pull/2895 part 2: https://github.com/aws-amplify/amplify-android/pull/2896 part 3: https://github.com/aws-amplify/amplify-android/pull/2899

  • [x] PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Add integration tests for providing a bucket option when executing Storage apis (list, remove, getUrl, download, and upload)
  • Update existing storage integration tests with teardown code to clean up test resources that were uploaded to S3
  • Fix missing code in AWSS3StoragePlugin that gets the AWSS3StorageService if a bucket is provided in options parameter
  • Minor spacing/formatting update in TransferTable

How did you test these changes? (Please add a line here how the changes were tested) Ran Storage integration test suite in local Android Studio

Documentation update required?

  • [x] No
  • [ ] Yes (Please include a PR link for the documentation update)

General Checklist

  • [ ] ~Added Unit Tests~
  • [x] Added Integration Tests
  • [x] Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

phantumcode avatar Aug 21 '24 19:08 phantumcode