configure-aws-credentials icon indicating copy to clipboard operation
configure-aws-credentials copied to clipboard

runtime: upgrade to use nodejs v16

Open chenrui333 opened this issue 3 years ago • 2 comments

Issue #, if available:

Description of changes:

Node 12 has an end of life on April 30, 2022.

This PR updates the default runtime to node16, rather then node12.

This is supported on all Actions Runners v2.285.0 or later.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

chenrui333 avatar Apr 04 '22 19:04 chenrui333

Should be a major version bump per the PR merge.

chenrui333 avatar Apr 04 '22 19:04 chenrui333

Would love to see this one merged and a aws-actions/configure-aws-credentials@v2 released 👍

magnetikonline avatar Apr 28 '22 05:04 magnetikonline

@chenrui333 can you resolve the conflicts so we can get this merged?

der-eismann avatar Sep 21 '22 13:09 der-eismann

What is the state of this? I also got warnings in my workflow.

Pointing to https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Also happy to open a new PR to get this resolved. Please let me know.

marcofranssen avatar Oct 11 '22 07:10 marcofranssen

We're fully relying on this github action. As marcofranssen said, Node environment migration to Node16 on GitHub Action is in progress since September 27th. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

I hope this will be merged and released as soon as possible. Thanks

aewshyae avatar Oct 11 '22 07:10 aewshyae

I've Tweeted AWS they reply more often than you would think. 😄

Otherwise, might be good if some users with business support in AWS maybe open a new case/ticket to get some eyes on this ASAP?

At the very least the only change actually needed is (if in a pinch):

using: node16

the rest of the changes are good, but not critical path (just being aware there is a current conflict with master on this one).

If this does fail badly - my quick pivot will be a fork and patch of this action until this source action has been fixed/updated.

magnetikonline avatar Oct 12 '22 02:10 magnetikonline

Hi folks, I resolved the conflicts on this branch and opened a new PR with @chenrui333's changes: https://github.com/aws-actions/configure-aws-credentials/pull/520

Please have a look and let me know if I need to change anything else.

FunctionalWorm avatar Oct 12 '22 05:10 FunctionalWorm

Would love to see this PR get merged

just-Bri avatar Oct 12 '22 16:10 just-Bri

We really appreciate the contribution @chenrui333,

However I will be closing this out because a newer PR with resolved merge conflicts has been opened #520, and we might not be able to merge that either. See this comment for more info on the plan to update runtime, and please refer to that thread for future updates and concerns regarding this topic. Thanks!

peterwoodworth avatar Oct 12 '22 22:10 peterwoodworth