aws-actions
feat: add retry logic to assume role
Issue #, if available: #299
Description of changes: Add retry logic to assume role function
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Any update on this? Should we tag someone from the aws-actions org to look at it?
It would be great to see this merged - we are getting impacted in production by OIDC failures as a result of this.
Tagging @mattsb42-aws and @clareliguori
It would be great to see this merged - we are getting impacted in production by OIDC failures as a result of this.
Tagging @mattsb42-aws and @clareliguori
Hi @GarethLoweCinch , We (ECS Team) are looking into the issue and we were able to reproduce the issue on our side. We are investigating on the solution right now, so we will keep you posted about it. FYI @efekarakus
We are facing this issue as well. It would be great to have this PR merged or the issue fixed another way. FYI: @winglot
Envoyé de mon iPhone
Le 9 déc. 2021 à 07:24, Alex Kulikovskikh @.***> a écrit :
Issue #, if available:
Description of changes: Add retry logic to assume role function
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
You can view, comment on, or merge this pull request online at:
https://github.com/aws-actions/configure-aws-credentials/pull/329
Commit Summary
2db9bc7 feat: add retry to assume role 462de15 fix: add retry & error handling c49a6a7 fix: retry 0d13664 fix: retry e502bb2 fix: reset dist & revert back error handling 3c17490 fix: add action input & fix package-lock.json 604305b chore: reset dist File Changes (5 files) M action.yml (6) M dist/index.js (240) M index.js (62) M package-lock.json (5568) M package.json (1) Patch Links:
https://github.com/aws-actions/configure-aws-credentials/pull/329.patch https://github.com/aws-actions/configure-aws-credentials/pull/329.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.
Hi there,
I've published this version on dannyburke1/[email protected] and set 10 parallel jobs to assume. Typically, this fails on one in 1 in 10 parallel builds, so it this was the best way to test it - however I'm not sure this is 100% retrying the call as I'm still getting failed builds even when setting the retry count to something ridiculous like 500, the error is returned and handled straight away rather than retrying and taking a few minutes- at least this is my experience. I've also tried catching some additional errors to see if that helped but unfortunately didn't. Happy to work with you and show you my changes in order to get this over the fence.
Cheers, Danny
@dannyburke1 Currently retrying limited to IDPCommunicationError and InvalidIdentityToken errors (from this list). It would be nice if you could share error codes/messages that you've encountered
Thanks for the submission! however it looks like this issue was fixed with #350 so I'll be closing this out. Ping me and let me know if you still think there's purpose for this solution
