configure-aws-credentials icon indicating copy to clipboard operation
configure-aws-credentials copied to clipboard

outputs.aws-account-id is not reflecting correctly anymore

Open ROglesby92 opened this issue 3 years ago • 1 comments

Before the latest release 1.6.0, I was able to reference the output of an account id from a configure-aws-credentials step like so:

e.g

     - name: Configure AWS Credentials for deployment
       id: aws-deploy-credentials
       uses: aws-actions/configure-aws-credentials@v1
       with:
          aws-region: us-west-2
          role-to-assume: arn:aws:iam::123456789:role/github-actions-runner
          role-duration-seconds: 900
      
     - name: Deploy
       ...
       env:
          QUEUE_URL: https://sqs.us-west-2.amazonaws.com/${{ steps.aws-deploy-credentials.outputs.aws-account-id }}/test

Expected results: QUEUE_URL should be set to https://sqs.us-west-2.amazonaws.com/123456789/test

Actual results: QUEUE_URL is now set to https://sqs.us-west-2.amazonaws.com/987654321/test

Where 987654321 is the account ID from the Github Runners original role: arn:aws:iam::987654321:role/github-actions-runner

This caused some bad deploys to happen as my resource naming convention referenced the deploying role account id, had to end up making those values static instead

ROglesby92 avatar Dec 03 '21 01:12 ROglesby92

Hey @ROglesby92, are you using OIDC to authenticate?

peterwoodworth avatar Oct 04 '22 23:10 peterwoodworth

⚠️Comment Visibility Warning⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

github-actions[bot] avatar Feb 21 '23 23:02 github-actions[bot]