aws-secretsmanager-get-secrets icon indicating copy to clipboard operation
aws-secretsmanager-get-secrets copied to clipboard

Remove uppercase enforcement of environment variables

Open pcassaretto-cmc opened this issue 1 year ago • 1 comments

Currently environment vars must be uppercase, which prevents us from populating terraform input variables directly with this action. For example, we cannot do TF_VAR_secret_1 directly with this action and then need an intermediate action to take this output and set the correct terraform environment variable.

I think this should be allowed given the enormous popularity of terraform. Can't see any documented reasoning why you force the name to uppercase here https://github.com/aws-actions/aws-secretsmanager-get-secrets/blob/main/src/utils.ts#L189C54-L189C65

pcassaretto-cmc avatar Dec 21 '23 11:12 pcassaretto-cmc

Thank you for the request, we will look into this.

jbct avatar Feb 12 '24 19:02 jbct

We've added option name-transformation. Your use-case is covered by name-transformation: none. Please see the documentaiton or https://github.com/aws-actions/aws-secretsmanager-get-secrets/pull/139 for more info.

jirkafajfr avatar Jun 10 '24 15:06 jirkafajfr