aws-cloudformation-github-deploy
aws-cloudformation-github-deploy copied to clipboard
action deploys stack even if 'no-execute-changeset' is set
Steps to Reproduce
-
Use the following GitHub Action configuration to deploy a CloudFormation stack:
- name: deploy using CloudFormation uses: aws-actions/aws-cloudformation-github-deploy@master with: name: foobar template: template.yaml capabilities: ... no-execute-changeset: "1" -
Ensure the CloudFormation stack does not exist before running the action.
-
The stack is deployed despite
no-execute-changesetbeing set to"1".
Expected Behavior
A stack should be created, but with REVIEW_IN_PROGRESS.
Relevant Code
The issue appears to be in the deployStack function where the existence of the stack is checked. If the stack does not exist, a new stack is created without considering the no-execute-changeset flag. permalink