amazon-ecs-render-task-definition icon indicating copy to clipboard operation
amazon-ecs-render-task-definition copied to clipboard

Published 20 hours ago • verified publisher icon aws-actions

Node16 deprecation warning

Open christian-ci opened this issue 1 year ago • 6 comments

Describe the bug The GitHub Actions workflow is generating a deprecation warning due to the use of Node.js 16. GitHub Actions now requires the use of Node.js 20, as Node.js 16 actions have been deprecated.

To Reproduce Steps to reproduce the behavior:

  1. Go to the GitHub repository containing the workflow.
  2. Run the GitHub Actions workflow.
  3. Observe the deprecation warning in the workflow logs.
  4. The warning specifically mentions the use of Node.js 16 in aws-actions/amazon-ecs-render-task-definition@v1.

Expected behavior The expected behavior is for the GitHub Actions workflow to run without any deprecation warnings. It should use the updated Node.js 20 environment for all actions.

Screenshots Screenshot 2024-01-25 at 15 58 40

Desktop (please complete the following information): OS Agnostic

Additional context The deprecation of Node.js 16 actions is part of GitHub's ongoing maintenance and update of their Actions infrastructure. More information about this transition can be found at: GitHub Blog Changelog.

christian-ci avatar Jan 25 '24 18:01 christian-ci

I too would like to have GitHub logs free of warnings.

DanielLaberge avatar Feb 20 '24 17:02 DanielLaberge

https://github.com/aws-actions/amazon-ecs-render-task-definition/pull/287

How can we have this PR merged?

martingleria avatar Mar 04 '24 19:03 martingleria

Is this action still supported by AWS or do I (we) need to start looking at alternatives?

jeropaul avatar Mar 14 '24 00:03 jeropaul

Not really sure. Why not like tag whoever worked on the last PRs that were merged.

christian-ci avatar Mar 14 '24 01:03 christian-ci

Progress! #287 has been merged so now we just need a new release...

jeropaul avatar Mar 18 '24 00:03 jeropaul

@iamhopaul123 is there any way you could cut a new release? Thanks!

jlauzze avatar Mar 19 '24 15:03 jlauzze

@iamhopaul123 Ping, please create a new release bro, Thanks!

nireld avatar Apr 04 '24 09:04 nireld

Asking for a new release too. Please and thank you!

AlbertCintas avatar Apr 06 '24 09:04 AlbertCintas

Another ask for a new release please, I don't like warnings.

aiell0 avatar Apr 10 '24 14:04 aiell0

Is anyone still maintaining this?

ghosttown

baraknaveh avatar Apr 10 '24 17:04 baraknaveh

Anyone know anyone @aws that can put some heat under this?

jensenbox avatar Apr 17 '24 03:04 jensenbox

Not ideal, but until a release is cut, we can pin to the commit sha that includes the node20 fixes. Our team has done it for the time being, no more run warnings, and everything has been working fine. Just a suggestion, it may not be an adequate solution for all.

uses: aws-actions/amazon-ecs-render-task-definition@35d224b2ca3f343a8b46e0362c097786a88513bb

jlauzze avatar Apr 17 '24 17:04 jlauzze

Thanks @jlauzze for this -- good idea!

baraknaveh avatar Apr 17 '24 21:04 baraknaveh

Thank you @jlauzze! Good idea!

AlbertCintas-insurteam avatar Apr 23 '24 16:04 AlbertCintas-insurteam

Thank you for your patience. Node.js 20 upgrade was released with PR 287 as part of Release v1.3.0.

amazreech avatar May 08 '24 19:05 amazreech

FINALLY!

nireld avatar May 08 '24 19:05 nireld