amazon-ecs-render-task-definition icon indicating copy to clipboard operation
amazon-ecs-render-task-definition copied to clipboard

add inputs executionRoleArn and taskRoleArn

Open hblab-ngocnd opened this issue 2 years ago • 3 comments

for security reason, want add input executionRoleArn and taskRoleArn for task definition

hblab-ngocnd avatar Sep 01 '22 01:09 hblab-ngocnd

You can simply do this by adding it to the task-definition . E.g.

  "TaskDefinition": {
    "executionRoleArn": "arn:aws:iam::<id>:role/<name>",
    "containerDefinitions": [
      {
...

bert2002 avatar Sep 04 '22 08:09 bert2002

@bert2002 But that not good for security because that show Arn Role for viewer. It is better If input has options for set role from secret key by input

https://github.com/aws-actions/amazon-ecs-render-task-definition/blob/74bfbc88d5d3a3c237d9b643ed1b18546483b89e/action.yml#L6-L18

hblab-ngocnd avatar Sep 05 '22 01:09 hblab-ngocnd

I agree, hardcoding the parameters in the task-definition is not useful. Can we prioritize this feature request?

dangeReis avatar Jun 03 '24 19:06 dangeReis