amazon-ecs-render-task-definition icon indicating copy to clipboard operation
amazon-ecs-render-task-definition copied to clipboard
verified publisher icon aws-actions

feat: support secrets in render task definition

Open yehudacohen opened this issue 3 years ago • 4 comments

Issue #, if available: #20 Description of changes: Add ability to add secrets to task definition. There is already a pull request here #143 which tries to do this, but it isn't backward compatible. This pull request is. It also doesn't add tests which this PR does.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

yehudacohen avatar Jan 26 '22 14:01 yehudacohen

👍 we'd love to use this feature. What's blocking?

kroehre avatar Apr 26 '22 22:04 kroehre

Hi 👋 Any updates about when this will be merged? I think it's a needed feature 🙏

cairesvs avatar Nov 06 '23 13:11 cairesvs

Hi there, any update on this?

canhassancode avatar Mar 28 '24 11:03 canhassancode

Hi @yehudacohen, thank you so much for your contribution. Apologies on the delay. We will be working on reviewing Pull Requests on the repository. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please be sure to run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR if any.

amazreech avatar May 10 '24 18:05 amazreech