amazon-ecs-render-task-definition icon indicating copy to clipboard operation
amazon-ecs-render-task-definition copied to clipboard
verified publisher icon aws-actions

(feat) add support to secrets (SSM and Secrets Manager)

Open hectorgrecco opened this issue 4 years ago • 1 comments

Issue #, if available: We currently have support for fixed environment variables, but not for sensitive data store at SSM or Secrets Manager.

Description of changes: I've added a parameter named secrets where you can set SECRET_NAME=AWS_ARN value. I've added a Regex to validate the ARN. I did not write tests, so... If someone could write those tests, the community would be happy :)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

hectorgrecco avatar Dec 10 '21 11:12 hectorgrecco

Hi @hectorgrecco, thank you so much for your contribution. Apologies on the delay. We will be working on reviewing Pull Requests on the repository. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please be sure to run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR if any.

amazreech avatar May 10 '24 18:05 amazreech

Hi @hectorgrecco, closing this PR out. Similar changes have been submitted as part of PR 152. PR 152 also attributes this PR in their description and is currently under review.

I will add you as a co-contributor you when we merge the other PR. Please let me know if you have any concerns. Thank you!

amazreech avatar Sep 27 '24 20:09 amazreech