amazon-ecs-render-task-definition icon indicating copy to clipboard operation
amazon-ecs-render-task-definition copied to clipboard
verified publisher icon aws-actions

feat: add docker labels

Open AhnSeongHyun opened this issue 4 years ago • 3 comments

Issue #, if available:

Description of changes:

  • Add docker-labels to optional action input(action.yml)
  • Apply docker-labes to ecs task definition dockerLabels.
  • Add test to empty case and update case.
  • Update README

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AhnSeongHyun avatar Nov 26 '21 03:11 AhnSeongHyun

what is problem??

AhnSeongHyun avatar Nov 29 '21 12:11 AhnSeongHyun

Since AWS Fargate does not copy image labels to the containers, this change would be welcome. Otherwise it's pretty hard to add a git commit sha as a label to the container.

v3rm0n avatar Jun 20 '23 13:06 v3rm0n

Are there any issues with this? It would be a really useful feature.

justin1291 avatar Aug 08 '23 23:08 justin1291

Hi @AhnSeongHyun, thank you so much for your contribution. Apologies on the delay. We will be working on reviewing this Pull Request. In the mean time please ensure that below steps, if not already done, are taken care of in your PR:

  1. Verify if PR follows semantic pull request conventions.

  2. Please be sure to run npm run package command to update dist/ folder with latest dependencies.

  3. Resolve merge conflicts on the PR if any.

amazreech avatar May 10 '24 18:05 amazreech

This feature should be covered by PR 274. Please feel free to re-open if the issue is not addressed.

amazreech avatar May 22 '24 18:05 amazreech